Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terraform steps in CI PR #2 #8147

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Fix terraform steps in CI PR #2 #8147

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
320f6a3
Attempt to conditionally run terraform steps only if secrets are avai…
MarkDuckworth Apr 9, 2024
c2f5c69
Add fromJSON to convert env var string value to boolean.
MarkDuckworth Apr 10, 2024
50dbc01
Merge branch 'master' of github.com:firebase/firebase-js-sdk into mar…
MarkDuckworth Apr 10, 2024
52cc75b
Revert version bump for google-github-actions/auth
MarkDuckworth Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test-changed-firestore-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,23 +34,23 @@ jobs:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- uses: 'google-github-actions/auth@v0'
if: ${{ env.run_terraform_steps }}
if: ${{ fromJSON(env.run_terraform_steps) }}
with:
credentials_json: '${{ secrets.JSSDK_ACTIONS_SA_KEY }}'

# create composite indexes with Terraform
- name: Setup Terraform
if: ${{ env.run_terraform_steps }}
if: ${{ fromJSON(env.run_terraform_steps) }}
uses: hashicorp/setup-terraform@v2
- name: Terraform Init
if: ${{ env.run_terraform_steps }}
if: ${{ fromJSON(env.run_terraform_steps) }}
run: |
cp config/ci.config.json config/project.json
cd packages/firestore
terraform init
continue-on-error: true
- name: Terraform Apply
if: github.event_name == 'pull_request' && env.run_terraform_steps
if: github.event_name == 'pull_request' && fromJSON(env.run_terraform_steps)
run: |
cd packages/firestore

Expand Down
Loading