Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FirebaseServerApp] add a new serverapp type for usage tracking. #8094

Merged
merged 3 commits into from
Mar 23, 2024
Merged

[FirebaseServerApp] add a new serverapp type for usage tracking. #8094

merged 3 commits into from
Mar 23, 2024

Conversation

DellaBitta
Copy link
Contributor

Discussion

Add a new serverapp string for register version to track FirebaseServerApp usage.

Testing

CI.

API Changes

N/A.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 39508a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DellaBitta DellaBitta marked this pull request as ready for review March 22, 2024 22:04
@DellaBitta DellaBitta requested a review from a team as a code owner March 22, 2024 22:04
@DellaBitta DellaBitta requested review from jamesdaniels and removed request for a team March 22, 2024 22:04
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 22, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (9f74ac9)Merge (cd2119b)Diff
    browser18.0 kB18.0 kB+46 B (+0.3%)
    esm523.5 kB23.6 kB+46 B (+0.2%)
    main24.6 kB24.6 kB+46 B (+0.2%)
    module18.0 kB18.0 kB+46 B (+0.3%)

  • firebase

    TypeBase (9f74ac9)Merge (cd2119b)Diff
    firebase-app-compat.js31.4 kB31.4 kB+20 B (+0.1%)
    firebase-app.js102 kB102 kB+58 B (+0.1%)
    firebase-compat.js786 kB786 kB+22 B (+0.0%)
    firebase-performance-standalone-compat.es2017.js93.2 kB93.3 kB+20 B (+0.0%)
    firebase-performance-standalone-compat.js70.3 kB70.3 kB+22 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DMSnQSJ8Ge.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 22, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/app

    • initializeServerApp

      Size

      TypeBase (9f74ac9)Merge (cd2119b)Diff
      size11.2 kB11.2 kB+19 B (+0.2%)
      size-with-ext-deps25.0 kB25.1 kB+20 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/twHCuTzPuA.html

@DellaBitta DellaBitta merged commit db24403 into feature-firebaseserverapp Mar 23, 2024
41 checks passed
@DellaBitta DellaBitta deleted the ddb-serverapp-authstateready branch March 23, 2024 00:12
@firebase firebase locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DellaBitta @google-oss-bot @jamesdaniels