Fix for authStateReady for FirebaseServerApp #8085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jamesdaniels
changed the title
jamesdaniels
changed the title
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
jamesdaniels
requested review from
lisajian,
Xiaoshouzi-gh,
renkelvin,
sam-gc and
a team
as code owners
jamesdaniels
changed the title
jamesdaniels
requested review from
DellaBitta and
renkelvin
and removed request for
a team,
renkelvin,
sam-gc,
lisajian and
Xiaoshouzi-gh
DellaBitta
approved these changes
Mar 19, 2024
renkelvin
reviewed
Mar 20, 2024
| response, | ||
| idToken | ||
| ); | ||
| await this.directlySetCurrentUser(user); |
There was a problem hiding this comment.
Why use directlySetCurrentUser instead of updateCurrentUser? directlySetCurrentUser is rarely used.
There was a problem hiding this comment.
I noted that directlySetCurrentUser was what was being used elsewhere in initializeCurrentUser where I am calling this from. FWIW we have chosen to disable updateCurrentUser in FirebaseServerApp. I could use _updateCurrentUser as @DellaBitta did before but I was concerned that the side effects of notifying listeners and running middleware were undesirable during auth initialization and may lead to more race conditions and ill effects in developer's code.
There was a problem hiding this comment.
Perhaps I should rename this method, as it is more appropriately initializeCurrentUserFromIdToken
There was a problem hiding this comment.
Yeah, the concern of side effects of _updateCurrentUser makes sense to me. Thanks, let's keep directlySetCurrentUser then.
renkelvin
approved these changes
Mar 20, 2024
| response, | ||
| idToken | ||
| ); | ||
| await this.directlySetCurrentUser(user); |
There was a problem hiding this comment.
Yeah, the concern of side effects of _updateCurrentUser makes sense to me. Thanks, let's keep directlySetCurrentUser then.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the FirebaseServerApp implementation in #8005 was not blocking auth initialization, so when testing end-to-end we were seeing race conditions with auth state. In this PR I address by awaiting the user fetch and moving the implementation into
AuthImpl#initializeCurrentUserfor cleanliness.Mind taking a look @renkelvin?