-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More complex check for authTokenSyncUrl #8076
Conversation
🦋 Changeset detectedLatest commit: 939a060 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
I think we should. Sure, this is the browser bundle and it should never be run in Node, and the chart seems to cover all the browsers we support but I'm never sure about extensions, iframes, jsdom, and bad SSR configs where they end up pulling in the browser bundle in Node. |
b/327386166
FYI @hsubox76
Q, should we guard against isSecureContext not being available? Can I use isSecureContext?