Fix glob pattern to work with Node 20 and its NPM version #8059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cf8c12b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DellaBitta
approved these changes
Mar 8, 2024
Size Report 1Affected ProductsNo changes between base commit (feb5038) and merge commit (6145e29).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (feb5038) and merge commit (6145e29).Test Logs |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are upgrading all our Github workflows from Node 16 and Node 20, and noticed this broke E2E tests that install from NPM.
It seems sometime between Node 16 and Node 18 there may have been a bump in NPM version, and this NPM change has a difference in the way it handles glob patterns in the
filesfieldpackage.json. Previously we used the pattern"**/dist/"and it included any file in anydistfolder underpackages/firebase, but after the bump to Node 20 (and consequent NPM version bump) it only includedpackage.jsonfiles, no js or ts files, basically removing the entry points to all modular versions of products.When changed to
"**/dist/**/*", it seems to work as it previously did.If not fixed, this will break all releases.