Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServerApp] Mangle the FirebaseServerApp name #7993

Merged
merged 2 commits into from
Jan 30, 2024
Merged

[ServerApp] Mangle the FirebaseServerApp name #7993

merged 2 commits into from
Jan 30, 2024

Conversation

DellaBitta
Copy link
Contributor

Discussion

Mangle the name of the app based on the hash of the parameters passed in.
In addition, return the same app when the same parameters are used.

Testing

Added more unit tests.
CI.

API Changes

N/A.

@DellaBitta
Mangle app name, and test updates.
08104e7 
In addition, return the same app when the same parameters are used.
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7cecae5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DellaBitta DellaBitta changed the title [ServerAppMangle the FirebaseServerApp name [ServerApp] Mangle the FirebaseServerApp name Jan 30, 2024
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (562d619)Merge (a440c2c)Diff
    browser17.8 kB17.6 kB-158 B (-0.9%)
    esm523.2 kB22.9 kB-242 B (-1.0%)
    main24.2 kB24.0 kB-242 B (-1.0%)
    module17.8 kB17.6 kB-158 B (-0.9%)

  • firebase

    TypeBase (562d619)Merge (a440c2c)Diff
    firebase-app-compat.js31.2 kB31.1 kB-153 B (-0.5%)
    firebase-app.js100 kB100 kB-176 B (-0.2%)
    firebase-compat.js782 kB782 kB-153 B (-0.0%)
    firebase-performance-standalone-compat.es2017.js93.1 kB93.0 kB-150 B (-0.2%)
    firebase-performance-standalone-compat.js70.1 kB69.9 kB-195 B (-0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TT7B4QStaT.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/app

    • initializeServerApp

      Size

      TypeBase (562d619)Merge (a440c2c)Diff
      size11.1 kB10.9 kB-167 B (-1.5%)
      size-with-ext-deps24.9 kB24.7 kB-166 B (-0.7%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/66BG1YIQd5.html

@DellaBitta DellaBitta marked this pull request as ready for review January 30, 2024 15:37
@DellaBitta DellaBitta requested a review from a team as a code owner January 30, 2024 15:37
@DellaBitta DellaBitta merged commit abc9d87 into feature-firebaseserverapp Jan 30, 2024
41 checks passed
@DellaBitta DellaBitta deleted the ddb-serverapp-name-mangle branch January 30, 2024 15:51
@firebase firebase locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @google-oss-bot