-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore: update firestore-types with breaking API changes for FirestoreDataConverter #7423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for UpdateData from #7310
🦋 Changeset detectedLatest commit: f35f998 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsNo changes between base commit (f3067f7) and merge commit (b1823ca).Test Logs |
Size Analysis Report 1This report is too large (1,841,654 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
…Type to DocumentData
…h other methods that use 'U' as a type parameter
hsubox76
approved these changes
Jul 6, 2023
ehsannas
approved these changes
Jul 6, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
index.d.ts
from thefirestore-types
package for theFirestoreDataConverter
breaking API changes from #7310.This fixes ~29 build errors that anyone using the
firestore-compat
library would get, that look like this:I tested this change by creating a new npm project and running
npm install firebase@next
and running this little test app: https://gist.github.com/dconeybe/cf113e198fe0e52283f0251fa0ff6899Googlers see b/290216686 for details.