Fix throttling for App Check to prevent unnecessary requests to backend #6439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0efea24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
hsubox76
reviewed
Jul 15, 2022
hsubox76
reviewed
Jul 18, 2022
packages/app-check/src/providers.ts
Outdated
| @@ -80,7 +80,10 @@ export class ReCaptchaV3Provider implements AppCheckProvider { | |||
| this._heartbeatServiceProvider! | |||
| ); | |||
| } catch (e) { | |||
| if ((e as FirebaseError).code === AppCheckError.FETCH_STATUS_ERROR) { | |||
| console.log({ coder: (e as FirebaseError).code }); | |||
There was a problem hiding this comment.
Is this left over from debugging?
There was a problem hiding this comment.
Yes! Good catch. Removing it now
| 'test error msg', | ||
| { httpStatus: 503 } | ||
| ) | ||
| ERROR_FACTORY.create(AppCheckError.FETCH_STATUS_ERROR, { |
There was a problem hiding this comment.
Thanks for fixing the test!
hsubox76
approved these changes
Jul 18, 2022
egilmorez
pushed a commit
that referenced
this pull request
Jul 19, 2022
…nd (#6439) * Switch check for FirebaseError code to use includes * Add changeset * Update changeset to a patch * Remove debugging console.log
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch check for FirebaseError code to use includes #6373