Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add type check for process.env #5790

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

nandenjin
Copy link
Contributor

Fixes #5789

This PR adds type checks for process.env to avoid TypeError when process.env is undefined although process is defined.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2021

⚠️ No Changeset found

Latest commit: c3c85d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Dec 5, 2021
@nandenjin nandenjin changed the title fix: Add type check for process.env fix: Add type check for process.env Dec 5, 2021
@nandenjin
Copy link
Contributor Author

@schmidt-sebastian @jsdt 4 months passed, how is it going now?

@schmidt-sebastian
Copy link
Contributor

Sorry I did not see this PR.

@schmidt-sebastian schmidt-sebastian merged commit 7009181 into firebase:master Apr 11, 2022
@firebase firebase locked and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'FIREBASE_DATABASE_EMULATOR_HOST')
2 participants