-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth heartbeat implementation #5782
base: main
Are you sure you want to change the base?
Conversation
|
Well I meant to open this as a draft but apparently I can't do that after opening it for real (by accident) |
Binary Size ReportAffected SDKs
Test Logs |
Size Analysis ReportAffected Products
|
This is possible and I just did that for you. Next time you can try searching "draft" on the page (Ctrl/Cmd-F) -- it's hidden in a corner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks reasonable, but is there an (internal) design doc for why we're doing this?
Will need a changeset when ready. I suggest waiting until the heartbeat controller PR (#5723) is merged, then rebasing this on master. The changeset tool gets a little confused when the base branch isn't master. |
DO NOT MERGE