Add public token API to AppCheck #5033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
egilmorez,
Feiyang1 and
hiranya911
as code owners
🦋 Changeset detectedLatest commit: 99f0293 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
kevinthecheung
approved these changes
Jun 16, 2021
Feiyang1
reviewed
Jun 17, 2021
Co-authored-by: Kevin Cheung <[email protected]>
…rebase-js-sdk into ch-appcheck-tokenapi
Feiyang1
suggested changes
Jun 23, 2021
packages/app-check/src/api.test.ts
Outdated
| const app = getFakeApp({ automaticDataCollectionEnabled: true }); | ||
| const fakePlatformLoggingProvider = getFakePlatformLoggingProvider(); | ||
| stub(internalApi, 'getToken').resolves({ | ||
| token: 'a-token-string', |
There was a problem hiding this comment.
It should be the dummy token in this case, right? Can you add a comment here to clarify?
| @@ -264,7 +277,11 @@ function createTokenRefresher( | |||
|
|
|||
| // getToken() always resolves. In case the result has an error field defined, it means the operation failed, and we should retry. | |||
| if (result.error) { | |||
| throw result.error; | |||
| if (onError) { | |||
| onError(result.error); | |||
There was a problem hiding this comment.
This is redundant. Notifying listeners are already handled in getToken() which calls notifyTokenListeners().
Here we should always throw to trigger retries. (Just revert the changes)
Feiyang1
approved these changes
Jun 23, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create public
getToken()andonTokenChanged()methods.Proposal (internal link):
go/app-check-sdk-get-token-3p-api
For docs reviewers:
The only public doc comments are in
packages/firebase/index.d.ts