Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for v9 & v9 compat interop #4911

Merged
merged 9 commits into from
May 25, 2021
Merged

Integration tests for v9 & v9 compat interop #4911

merged 9 commits into from
May 25, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: c14be98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@firebase/component Patch
@firebase/analytics Patch
@firebase/app-check Patch
@firebase/app Patch
@firebase/database Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/installations Patch
@firebase/messaging Patch
@firebase/performance Patch
@firebase/remote-config Patch
@firebase/rules-unit-testing Patch
@firebase/storage Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Feiyang1
Copy link
Member Author

@avolkovi As promised

jposuna
jposuna approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@jposuna jposuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for perf. Thanks for making these changes!

sam-gc
sam-gc approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Auth

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2021 •
edited
Loading

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

    • @firebase/functions-compat
    • @firebase/performance-compat
    • @firebase/remote-config-compat

    Make sure this was intentional.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 19, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/component

    Type Base (2a5039e) Head (f60a383) Diff
    browser 7.84 kB 7.95 kB +108 B (+1.4%)
    esm2017 5.88 kB 6.00 kB +122 B (+2.1%)
    main 8.18 kB 8.29 kB +111 B (+1.4%)
    module 7.84 kB 7.95 kB +108 B (+1.4%)

  • firebase

    Type Base (2a5039e) Head (f60a383) Diff
    firebase-app.js 21.8 kB 21.8 kB +49 B (+0.2%)
    firebase-database.js 187 kB 187 kB +49 B (+0.0%)
    firebase-performance-standalone.es2017.js 73.1 kB 73.2 kB +50 B (+0.1%)
    firebase-performance-standalone.js 49.6 kB 49.7 kB +49 B (+0.1%)
    firebase.js 888 kB 888 kB +48 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 19, 2021 •
edited
Loading

Size Analysis Report

Affected Products

  • @firebase/app-exp

    • initializeApp

      Size Table

      TypeBase (2a5039e)Head (f60a383)Diff
      size-with-ext-deps
      11.0 kB
      11.1 kB
      +84 B (+0.8%)

hsubox76
hsubox76 approved these changes May 20, 2021
View reviewed changes
packages/component/src/provider.ts Outdated Show resolved Hide resolved
@Feiyang1 Feiyang1 requested a review from egilmorez as a code owner May 21, 2021 17:35
@zwu52
Copy link
Member

zwu52 commented May 25, 2021

LGTM. Thanks for making 👍

@zwu52 zwu52 self-requested a review May 25, 2021 18:09
@Feiyang1 Feiyang1 merged commit 5fbc5fb into master May 25, 2021
@Feiyang1 Feiyang1 deleted the fei-compat-integration-test branch May 25, 2021 21:31
@google-oss-bot google-oss-bot mentioned this pull request Jun 2, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zwu52 zwu52 zwu52 approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@sam-gc sam-gc sam-gc approved these changes

@jposuna jposuna jposuna approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@zwu52 zwu52

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Feiyang1 @google-oss-bot @zwu52 @jposuna @sam-gc @hsubox76