Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log correct version for v9 Firestore and RTDB #4842

Merged
merged 10 commits into from
May 4, 2021
Merged

Log correct version for v9 Firestore and RTDB #4842

merged 10 commits into from
May 4, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 646df6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 28, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/database-exp

    Type Base (919413c) Head (99bff18) Diff
    browser 245 kB 245 kB +110 B (+0.0%)
    main 277 kB 277 kB +83 B (+0.0%)
    module 245 kB 245 kB +110 B (+0.0%)

  • @firebase/firestore

    Type Base (919413c) Head (99bff18) Diff
    browser 283 kB 283 kB +4 B (+0.0%)
    main 529 kB 529 kB +44 B (+0.0%)
    module 283 kB 283 kB +4 B (+0.0%)

  • @firebase/firestore-compat

    Type Base (919413c) Head (99bff18) Diff
    browser 28.4 kB 28.5 kB +120 B (+0.4%)
    main 37.4 kB 37.5 kB +120 B (+0.3%)
    module 28.4 kB 28.5 kB +120 B (+0.4%)
    react-native 28.1 kB 28.3 kB +120 B (+0.4%)

  • @firebase/firestore-exp

    Type Base (919413c) Head (99bff18) Diff
    browser 223 kB 223 kB +76 B (+0.0%)
    main 505 kB 505 kB +119 B (+0.0%)
    module 223 kB 223 kB +76 B (+0.0%)
    react-native 223 kB 223 kB +64 B (+0.0%)

  • @firebase/firestore-lite

    Type Base (919413c) Head (99bff18) Diff
    browser 71.4 kB 71.5 kB +83 B (+0.1%)
    main 145 kB 145 kB +127 B (+0.1%)
    module 71.4 kB 71.5 kB +83 B (+0.1%)
    react-native 71.6 kB 71.7 kB +74 B (+0.1%)

  • @firebase/firestore/bundle

    Type Base (919413c) Head (99bff18) Diff
    main 525 kB 525 kB +44 B (+0.0%)

  • @firebase/firestore/memory

    Type Base (919413c) Head (99bff18) Diff
    main 323 kB 324 kB +44 B (+0.0%)

  • @firebase/firestore/memory-bundle

    Type Base (919413c) Head (99bff18) Diff
    main 320 kB 320 kB +44 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

Diffs between base commit (919413c) and head commit (94ffdd8) are too large (479,509 characters) to display.

Please check below links to see details from the original test log.

schmidt-sebastian
schmidt-sebastian reviewed Apr 28, 2021
View reviewed changes
packages/firestore/lite/register.ts Outdated
@@ -29,6 +34,7 @@ declare module '@firebase/component' {
}

export function registerFirestore(): void {
setSDKVersion(SDK_VERSION);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we differentiate Firestore lite from Firestore? I wonder if we should prefix or postfix this with lite.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like 9.0.0-beta.1_lite?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we normally put variant info in the product string and not in the version number string? It's already in the product string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product string is in line 55, I think that should be enough to distinguish for platform logging, unless this is for Firestore-only backend logging? I think it might make platform logging queries a little harder to have one version not like the others.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is logged to Firestore backend directly. We will have to do some data massage to join Firestore data with platform logging data.

schmidt-sebastian
schmidt-sebastian approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint.

@Feiyang1
Copy link
Member Author

I swear I ran lint locally and everything passed!

@Feiyang1 Feiyang1 merged commit d095ad3 into master May 4, 2021
@Feiyang1 Feiyang1 deleted the fei-v-v9 branch May 4, 2021 06:24
@firebase firebase locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@jsdt jsdt Awaiting requested review from jsdt

Assignees

@Feiyang1 Feiyang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Feiyang1 @google-oss-bot @hsubox76 @schmidt-sebastian