Get closure-library from google-closure-library. #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-builder so we can control the version directly.
mikelehen
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
schmidt-sebastian
approved these changes
Jan 9, 2020
| @@ -16,6 +16,7 @@ | |||
| "license": "Apache-2.0", | |||
| "devDependencies": { | |||
| "closure-builder": "2.3.8", | |||
| "google-closure-library": "^20200101.0.0", | |||
There was a problem hiding this comment.
We don't use version ranges in the Web SDK. Not that it matters for this versioning scheme, but it might be better to be consistent and drop the ^.
There was a problem hiding this comment.
Oops! I just did "npm install --save-dev" or some such... Thanks. I'll remember this for next time!
|
@hsubox76 Can you approve the yarn.lock change? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get closure-library from google-closure-library instead of via closure-builder so we can control the version directly.