Skip to content

Commit

Permalink
Disable React Native build (#3244)
Browse files Browse the repository at this point in the history
* Disable React Native build

* Also remove from Firebase build

* Rollup cleanup
  • Loading branch information
schmidt-sebastian authored and Feiyang1 committed Jun 20, 2020
1 parent 311d4b5 commit 65945ab
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 29 deletions.
1 change: 0 additions & 1 deletion packages/firebase/src/index.rn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import '../database';
// TODO(b/158625454): Storage doesn't actually work by default in RN (it uses
// `atob`). We should provide a RN build that works out of the box.
import '../storage';
import '../firestore';

firebase.registerVersion(name, version, 'rn');

Expand Down
1 change: 0 additions & 1 deletion packages/firestore/memory/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"description": "A memory-only build of the Cloud Firestore JS SDK.",
"main": "../dist/index.memory.node.cjs.js",
"main-esm2017": "../dist/index.memory.node.esm2017.js",
"react-native": "../dist/index.memory.rn.esm2017.js",
"browser": "../dist/index.memory.cjs.js",
"module": "../dist/index.memory.esm.js",
"esm2017": "../dist/index.memory.esm2017.js",
Expand Down
1 change: 0 additions & 1 deletion packages/firestore/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
},
"main": "dist/index.node.cjs.js",
"main-esm2017": "dist/index.node.esm2017.js",
"react-native": "dist/index.rn.esm2017.js",
"browser": "dist/index.cjs.js",
"module": "dist/index.esm.js",
"esm2017": "dist/index.esm2017.js",
Expand Down
27 changes: 1 addition & 26 deletions packages/firestore/rollup.config.es2017.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,31 +100,6 @@ const browserBuilds = [
}
];

const reactNativeBuilds = [
// Persistence build
{
input: 'index.rn.ts',
output: {
file: pkg['react-native'],
format: 'es',
sourcemap: true
},
plugins: browserBuildPlugins,
external: resolveBrowserExterns
},
// Memory-only build
{
input: 'index.rn.memory.ts',
output: {
file: path.resolve('./memory', memoryPkg['react-native']),
format: 'es',
sourcemap: true
},
plugins: browserBuildPlugins,
external: resolveBrowserExterns
}
];

// MARK: Node builds

const nodeBuildPlugins = [
Expand Down Expand Up @@ -170,4 +145,4 @@ const nodeBuilds = [
}
];

export default [...browserBuilds, ...reactNativeBuilds, ...nodeBuilds];
export default [...browserBuilds, ...nodeBuilds];

0 comments on commit 65945ab

Please sign in to comment.