Add optimization to SortedSet.unionWith (#2624)

* Add optimization to SortedSet.unionWith * Add changelog. * Update changelog
firebase · Feb 13, 2020 · 2af214a · 2af214a
1 parent 41132fa
commit 2af214a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/packages/firestore/CHANGELOG.md b/packages/firestore/CHANGELOG.md
@@ -1,4 +1,6 @@
 # Unreleased
+- [fixed] Fixed a performance regression introduced by the addition of
+  `Query.limitToLast(n: number)` in Firestore 1.7.0 (Firebase 7.3.0) (#2620).
 - [fixed] Fixed an issue where `CollectionReference.add()` would reject
   custom types when using `withConverter()`. (#2606)
 

diff --git a/packages/firestore/src/util/sorted_set.ts b/packages/firestore/src/util/sorted_set.ts
@@ -135,6 +135,13 @@ export class SortedSet<T> {
 
   unionWith(other: SortedSet<T>): SortedSet<T> {
     let result: SortedSet<T> = this;
+
+    // Make sure `result` always refers to the larger one of the two sets.
+    if (result.size < other.size) {
+      result = other;
+      other = this;
+    }
+
     other.forEach(elem => {
       result = result.add(elem);
     });

diff --git a/packages/testing/src/api/index.ts b/packages/testing/src/api/index.ts
@@ -134,7 +134,7 @@ function initializeApp(
         ({
           getToken: async () => ({ accessToken: accessToken }),
           getUid: () => null,
-          addAuthTokenListener: (listener) => {
+          addAuthTokenListener: listener => {
             // Call listener once immediately with predefined accessToken.
             listener(accessToken);
           },