changes for rollup

config/api-extractor.json

@@ -100,7 +100,7 @@
      *
      * DEFAULT VALUE: false
      */
-    // "skipLibCheck": true,
+    "skipLibCheck": true,
   },
 
   /**

packages/analytics-compat/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "outDir": "dist"
   },
-  "exclude": [
-    "dist/**/*"
-  ]
-}
+  "exclude": ["dist/**/*"]
+}

packages/analytics-interop-types/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
+  "exclude": ["dist/**/*"]
 }

packages/analytics-types/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
+  "exclude": ["dist/**/*"]
 }

packages/analytics/rollup.config.js

@@ -22,14 +22,18 @@ import typescript from 'typescript';
 import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
 import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
 import pkg from './package.json';
+import tsconfig from './tsconfig.json';
 
 const deps = [
   ...Object.keys(Object.assign({}, pkg.peerDependencies, pkg.dependencies))
 ];
 
 const buildPlugins = [
   typescriptPlugin({
-    typescript
+    typescript,
+    tsconfigOverride: {
+      exclude: [...tsconfig.exclude, '**/*.test.ts']
+    }
   }),
   json({ preferConst: true })
 ];

packages/app-check-interop-types/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
+  "exclude": ["dist/**/*"]
 }

packages/app-check-types/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
+  "exclude": ["dist/**/*"]
 }

packages/app-types/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
+  "exclude": ["dist/**/*"]
 }

packages/app/rollup.config.js

@@ -23,14 +23,18 @@ import dts from 'rollup-plugin-dts';
 import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
 import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
 import pkg from './package.json';
+import tsconfig from './tsconfig.json';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
 );
 
 const buildPlugins = [
   typescriptPlugin({
-    typescript
+    typescript,
+    tsconfigOverride: {
+      exclude: [...tsconfig.exclude, '**/*.test.ts']
+    }
   }),
   json({ preferConst: true })
 ];

packages/app/tsconfig.json

@@ -4,7 +4,5 @@
     "outDir": "dist",
     "downlevelIteration": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
-}
+  "exclude": ["dist/**/*"]
+}

packages/auth-compat/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "outDir": "dist"
   },
-  "exclude": [
-    "dist/**/*"
-  ]
-}
+  "exclude": ["dist/**/*"]
+}

packages/auth-interop-types/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
+  "exclude": ["dist/**/*"]
 }

packages/auth-types/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
+  "exclude": ["dist/**/*"]
 }

packages/auth/rollup.config.js

@@ -24,6 +24,7 @@ import alias from '@rollup/plugin-alias';
 import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
 import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
 import pkg from './package.json';
+import tsconfig from './tsconfig.json';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
@@ -47,7 +48,10 @@ const nodeAliasPlugin = alias({
 const buildPlugins = [
   json(),
   strip({ functions: ['debugAssert.*'] }),
-  typescriptPlugin({ typescript })
+  typescriptPlugin({
+    typescript,
+    tsconfigOverride: { exclude: [...tsconfig.exclude, '**/*.test.ts'] }
+  })
 ];
 
 const browserBuilds = [
@@ -191,6 +195,7 @@ const webWorkerBuild = {
     }),
     typescriptPlugin({
       typescript,
+      exclude: [...tsconfig.exclude, '**/*.test.*'],
       compilerOptions: {
         lib: [
           // Remove dom after we figure out why navigator stuff doesn't exist

packages/auth/tsconfig.json

@@ -3,8 +3,5 @@
   "compilerOptions": {
     "outDir": "dist"
   },
-  "exclude": [
-    "dist/**/*",
-    "demo/**/*"
-  ]
-}
+  "exclude": ["dist/**/*", "demo/**/*"]
+}

packages/component/rollup.config.js

@@ -19,12 +19,20 @@ import typescriptPlugin from 'rollup-plugin-typescript2';
 import typescript from 'typescript';
 import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
 import pkg from './package.json';
+import tsconfig from './tsconfig.json';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
 );
 
-const buildPlugins = [typescriptPlugin({ typescript })];
+const buildPlugins = [
+  typescriptPlugin({
+    typescript,
+    tsconfigOverride: {
+      exclude: [...tsconfig.exclude, '**/*.test.ts']
+    }
+  })
+];
 
 const esmBuild = {
   input: 'index.ts',

packages/component/src/provider.ts

@@ -319,15 +319,15 @@ export class Provider<T extends Name> {
         instanceIdentifier: normalizeIdentifierForFactory(instanceIdentifier),
         options
       });
-      this.instances.set(instanceIdentifier, instance);
+      this.instances.set(instanceIdentifier, instance!);
       this.instancesOptions.set(instanceIdentifier, options);
 
       /**
        * Invoke onInit listeners.
        * Note this.component.onInstanceCreated is different, which is used by the component creator,
        * while onInit listeners are registered by consumers of the provider.
        */
-      this.invokeOnInitCallbacks(instance, instanceIdentifier);
+      this.invokeOnInitCallbacks(instance!, instanceIdentifier);
 
       /**
        * Order is important
@@ -339,7 +339,7 @@ export class Provider<T extends Name> {
           this.component.onInstanceCreated(
             this.container,
             instanceIdentifier,
-            instance
+            instance!
           );
         } catch {
           // ignore errors in the onInstanceCreatedCallback

packages/component/tsconfig.json

@@ -4,7 +4,5 @@
     "outDir": "dist",
     "downlevelIteration": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
-}
+  "exclude": ["dist/**/*"]
+}

packages/data-connect/rollup.config.js

@@ -22,6 +22,7 @@ import typescript from 'typescript';
 import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
 import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
 import pkg from './package.json';
+import tsconfig from './tsconfig.json';
 
 const deps = [
   ...Object.keys({ ...pkg.peerDependencies, ...pkg.dependencies }),
@@ -38,6 +39,9 @@ function onWarn(warning, defaultWarn) {
 const buildPlugins = [
   typescriptPlugin({
     typescript,
+    tsconfigOverride: {
+      exclude: [...tsconfig.exclude, '**/*.test.ts']
+    },
     abortOnError: false
   }),
   json({ preferConst: true })

packages/data-connect/tsconfig.json

@@ -4,8 +4,5 @@
     "outDir": "dist",
     "strict": false
   },
-  "exclude": [
-    "dist/**/*",
-    "test/**/*"
-  ]
+  "exclude": ["dist/**/*", "test/**/*"]
 }

packages/database-compat/tsconfig.json

@@ -5,7 +5,5 @@
     "strict": false,
     "downlevelIteration": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
-}
+  "exclude": ["dist/**/*"]
+}

packages/database-types/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
+  "exclude": ["dist/**/*"]
 }

packages/database/rollup.config.js

@@ -22,6 +22,7 @@ import typescript from 'typescript';
 import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
 import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
 import pkg from './package.json';
+import tsconfig from './tsconfig.json';
 
 const deps = [
   ...Object.keys({ ...pkg.peerDependencies, ...pkg.dependencies }),
@@ -38,6 +39,9 @@ function onWarn(warning, defaultWarn) {
 const buildPlugins = [
   typescriptPlugin({
     typescript,
+    tsconfigOverride: {
+      exclude: [...tsconfig.exclude, '**/*.test.ts']
+    },
     abortOnError: false
   }),
   json({ preferConst: true })

packages/database/tsconfig.json

@@ -5,7 +5,5 @@
     "strict": false,
     "downlevelIteration": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
-}
+  "exclude": ["dist/**/*"]
+}

packages/firebase/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "outDir": "dist"
   },
-  "exclude": [
-    "**/dist/**/*"
-  ]
-}
+  "exclude": ["**/dist/**/*"]
+}

packages/firestore-types/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
+  "exclude": ["dist/**/*"]
 }

packages/firestore/rollup.config.js

@@ -28,13 +28,15 @@ import typescript from 'typescript';
 import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
 
 import pkg from './package.json';
+import tsconfig from './tsconfig.json';
 
 const sourcemaps = require('rollup-plugin-sourcemaps');
 const util = require('./rollup.shared');
 
 const nodePlugins = [
   typescriptPlugin({
     typescript,
+    exclude: [...tsconfig.exclude, '**/*.test.ts'],
     cacheDir: tmp.dirSync(),
     abortOnError: true,
     transformers: [util.removeAssertTransformer]
@@ -48,6 +50,7 @@ const nodePlugins = [
 const browserPlugins = [
   typescriptPlugin({
     typescript,
+    exclude: [...tsconfig.exclude, '**/*.test.ts'],
     cacheDir: tmp.dirSync(),
     abortOnError: true,
     transformers: [util.removeAssertAndPrefixInternalTransformer]

packages/firestore/rollup.shared.js

@@ -22,7 +22,6 @@ const typescriptPlugin = require('rollup-plugin-typescript2');
 const typescript = require('typescript');
 const { terser } = require('@rollup/plugin-terser');
 const path = require('path');
-const sourcemaps = require('rollup-plugin-sourcemaps');
 
 const { renameInternals } = require('./scripts/rename-internals');
 const { extractPublicIdentifiers } = require('./scripts/extract-api');

packages/firestore/test/unit/specs/describe_spec.ts

@@ -300,8 +300,8 @@ function stringifyGroup(s: string): number {
  * some logically-first keys before others.
  */
 function stringifyComparator(
-  a: { key: string, value: unknown },
-  b: { key: string, value: unknown }
+  a: { key: string; value: unknown },
+  b: { key: string; value: unknown }
 ): number {
   const aGroup = stringifyGroup(a.key);
   const bGroup = stringifyGroup(b.key);

packages/functions-compat/tsconfig.json

@@ -3,7 +3,5 @@
   "compilerOptions": {
     "outDir": "dist"
   },
-  "exclude": [
-    "dist/**/*"
-  ]
-}
+  "exclude": ["dist/**/*"]
+}