Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift integration tests to macOS and tvOS builds #3336

Merged
merged 15 commits into from
Jul 12, 2019

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jul 11, 2019

This is re-attempting the changes in #3284.

The project configuration differences that prevented that PR from going through have been addressed in #3296, #3315, and #3324

Note the diffbase on #3335.

@wilhuff wilhuff requested a review from a user July 11, 2019 18:29
@wilhuff wilhuff assigned ghost Jul 11, 2019
.travis.yml Outdated
@@ -432,3 +432,4 @@ jobs:
branches:
only:
- master
- wilhuff/swift-integration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -- that was the last commit and it enables testing in travis. Part of resolving and removing the diffbase for the PR will be to remove it. Without this no tests will run until after the PR is retargeted at master.

@wilhuff wilhuff changed the base branch from wilhuff/benchmarks to master July 12, 2019 00:23
@wilhuff wilhuff merged commit 79627a2 into master Jul 12, 2019
@wilhuff wilhuff deleted the wilhuff/swift-integration branch July 12, 2019 01:29
@firebase firebase locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants