Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: sort strings in UTF-8 encoded byte order #14312

Merged
merged 3 commits into from
Jan 15, 2025
Merged

FIX: sort strings in UTF-8 encoded byte order #14312

merged 3 commits into from
Jan 15, 2025

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Jan 7, 2025 •
edited
Loading

#no-changelog

Adding test cases for sorting strings when special characters are included.

Other SDKs requires fix:
Java: googleapis/java-firestore#1967
Node: googleapis/nodejs-firestore#2275
Android: firebase/firebase-android-sdk#6615
Web: firebase/firebase-js-sdk#8691

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@milaGGL milaGGL marked this pull request as ready for review January 10, 2025 15:20
@milaGGL milaGGL changed the title sort strings in UTF-8 encoded byte order FIX: sort strings in UTF-8 encoded byte order Jan 13, 2025
@milaGGL milaGGL merged commit a34d7ae into main Jan 15, 2025
34 of 35 checks passed
@milaGGL milaGGL deleted the mila/fix-string-comparison branch January 15, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@milaGGL milaGGL

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milaGGL @google-oss-bot @ehsannas