Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge updated index.d.ts and TypeDoc assets to master branch #554

Merged
merged 24 commits into from
Jun 5, 2019

Conversation

egilmorez
Copy link
Contributor

No description provided.

hiranya911 and others added 23 commits April 4, 2019 13:26
* Adding commenting for Admin and Storage.

* Addressing feedback from hiranya911.
* Adding commenting for Admin and Storage.

* Addressing feedback from hiranya911.

* Adding commenting for admin.Messaging and others.

* Fixing some issues found by hiranya911.

* Adding correct indenting in line 1909.
* Adding commenting for Admin and Storage.

* Addressing feedback from hiranya911.

* Adding commenting for admin.Messaging and others.

* Fixing some issues found by hiranya911.

* Adding correct indenting in line 1909.

* Adding commmenting for admin.Auth classes and fleshing out TOC.

* Making fixes requeted by bojeil-google.

* Fixing one last alignment issue.
* Adding commenting for Admin and Storage.

* Addressing feedback from hiranya911.

* Adding commenting for admin.Messaging and others.

* Fixing some issues found by hiranya911.

* Adding correct indenting in line 1909.

* Adding commmenting for admin.Auth classes and fleshing out TOC.

* Making fixes requeted by bojeil-google.

* Fixing one last alignment issue.

* Adding comments for Auth methods.

* Addressing feedback from bojeil-goole.

* Second attempt to view and address *all* comments from bojeil-google.

* Removing unnecessary whitespace.

* Fixing what we think and hope is the last typo in this pull request.
* Adding comments for credential and database classes/methods.

* Fixing typo in example.

* Adding changes requested by hiranya911.

* Fixing a typo.

* Fixing the typo fixes.
* Adding comments for admin.projectManagement.

* Fixing misplaced comments for appId metadata.
* Adding commenting for Admin and Storage.

* Addressing feedback from hiranya911.
* Adding commenting for Admin and Storage.

* Addressing feedback from hiranya911.

* Adding commenting for admin.Messaging and others.

* Fixing some issues found by hiranya911.

* Adding correct indenting in line 1909.
* Adding commenting for Admin and Storage.

* Addressing feedback from hiranya911.

* Adding commenting for admin.Messaging and others.

* Fixing some issues found by hiranya911.

* Adding correct indenting in line 1909.

* Adding commmenting for admin.Auth classes and fleshing out TOC.

* Making fixes requeted by bojeil-google.

* Fixing one last alignment issue.
* Adding commenting for Admin and Storage.

* Addressing feedback from hiranya911.

* Adding commenting for admin.Messaging and others.

* Fixing some issues found by hiranya911.

* Adding correct indenting in line 1909.

* Adding commmenting for admin.Auth classes and fleshing out TOC.

* Making fixes requeted by bojeil-google.

* Fixing one last alignment issue.

* Adding comments for Auth methods.

* Addressing feedback from bojeil-goole.

* Second attempt to view and address *all* comments from bojeil-google.

* Removing unnecessary whitespace.

* Fixing what we think and hope is the last typo in this pull request.
* Adding comments for credential and database classes/methods.

* Fixing typo in example.

* Adding changes requested by hiranya911.

* Fixing a typo.

* Fixing the typo fixes.
* Adding comments for admin.projectManagement.

* Fixing misplaced comments for appId metadata.
@egilmorez egilmorez requested a review from hiranya911 June 5, 2019 23:26
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

src/index.d.ts Outdated
createIosApp(bundleId: string, displayName?: string): Promise<admin.projectManagement.IosApp>;
}
}

declare module 'firebase-admin' {
}

export = admin;
export = admin;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline at end of file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants