-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package.json to use farmhash 3.3.1 #2534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikeldridge
requested review from
lahirumaramba,
jenh,
sknopf,
trekforever and
amanda-xia
April 17, 2024 17:39
jenh
approved these changes
Apr 17, 2024
sknopf
approved these changes
Apr 17, 2024
erikeldridge
changed the title
Update package-lock to use farmhash 3.3.1
Update package.json to use farmhash 3.3.1
Apr 17, 2024
trekforever
approved these changes
Apr 17, 2024
lahirumaramba
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Erik!
For anyone who is experiencing broken A new |
This was referenced Jun 11, 2024
This was referenced Jun 13, 2024
This was referenced Sep 7, 2024
This was referenced Sep 13, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Version 12.1.0 of the Admin SDK added a dependency on a package called farmhash. This package has a dev dependency on python via node-gyp. The node-gyp package on older versions of Node looks for a binary called
python
. This results innpm install
of the Admin SDK failing if it can't find a binary with that name ("env: python: No such file or directory").Original error report: lovell/farmhash#47 (comment)
Fortunately, the owner of the farmhash package quickly added a prebuilt binary and released a version 3.3.1: lovell/farmhash#41
So, this PR updates the Admin SDK's package-lock.json to use farmhash version 3.3.1.
Folks can workaround this issue in the meantime by installing Python or aliasing an existing binary.
Testing
Steps to repro original issue:
nvm use 14
npm ci
python
binary:python3 -m venv ~/venv
source ~/venv/bin/activate
With this change:
nvm use 14
npm ci
API Changes
None