Fixes incorrect use of Object.assign
when backfilling SSRC config with defaults.
#2503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the logic where we backfill config with defaults, the first argument to
Object.assign
should be an object to assign to, but the code passed the object containing the defaults. It should be:Not:
The effect of the bug was to overwrite the defaults with the remote values, which is why in-app default would initially work, and updating to a remote value would work, but then switching back to in-app default wouldn't change the value from the previous remote value.
Discussion
Working with @lahirumaramba and @amanda-xia.
Testing
Ran
npm test
and all tests pass.Functionally tested using a local server.