Project config - Recaptcha config #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code.
Xiaoshouzi-gh
requested review from
lahirumaramba,
rsgowman and
renkelvin
and removed request for
rsgowman
renkelvin
reviewed
Mar 8, 2022
src/auth/tenant.ts
Outdated
| @@ -57,6 +57,7 @@ export interface UpdateTenantRequest { | |||
|
|
|||
| /** | |||
| * The recaptcha configuration to update on the tenant. | |||
| * By enabling reCAPTCHA Enterprise Integration you are agreeing to reCAPTCHA Enterprise Term of Service. | |||
| @@ -122,6 +122,15 @@ export { | |||
| TenantManager, | |||
| } from './tenant-manager'; | |||
|
|
|||
| export { | |||
| UpdateProjectConfigRequest, | |||
There was a problem hiding this comment.
Should we expose GetProjectConfigRequest here?
There was a problem hiding this comment.
We don't have a getProjectConfigRequest. It takes an empty object.
renkelvin
approved these changes
Mar 8, 2022
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Mar 2, 2023
* Recaptcha config changes in project config. - Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code. - Add Term of Service consents.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Mar 30, 2023
* Recaptcha config changes in project config. - Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code. - Add Term of Service consents.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 11, 2023
* Recaptcha config changes in project config. - Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code. - Add Term of Service consents.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 12, 2023
* Recaptcha config changes in project config. - Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code. - Add Term of Service consents.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 12, 2023
reCAPTCHA support * Defined reCAPTCHA config. (#1574) - Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config. * Create/Update tenant with ReCAPTCHA Config (#1586) * Support reCaptcha config /create update on tenants. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants operations. * Project config - Recaptcha config (#1595) * Recaptcha config changes in project config. - Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code. - Add Term of Service consents. * Recapcha integ test (#1599) * Added integ test for Project Config and Tenants update on reCAPTCHA config * Account defender support for reCAPTCHA (#1616) * Support use_account_defender add-on feature for reCAPTCHA config. * Added integration test for account defender feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recaptcha config changes in project config.
- Implemented getProjectConfig.
- Implemented updateProjectConfig.
- Updated error code.
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.