Adding the RTDB typings back #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshcrowthe
approved these changes
Nov 20, 2017
src/index.d.ts
Outdated
| hasChild(path: string): boolean; | ||
| hasChildren(): boolean; | ||
| numChildren(): number; | ||
| toJSON(): Object; |
There was a problem hiding this comment.
JS SDK has this line as Object | null
| } | ||
|
|
||
| interface OnDisconnect { | ||
| cancel(onComplete?: (a: Error|null) => any): Promise<void>; |
There was a problem hiding this comment.
JS SDK does Promise<any> here and on the rest of the functions in this interface.
There was a problem hiding this comment.
I will keep this unchanged for now, since we already seem to have some other (non-DB) APIs that return Promise<void>
src/index.d.ts
Outdated
| key: string|null; | ||
| parent: admin.database.Reference|null; | ||
| root: admin.database.Reference; | ||
|
|
| child(path: string): admin.database.Reference; | ||
| onDisconnect(): admin.database.OnDisconnect; | ||
| push(value?: any, onComplete?: (a: Error|null) => any): admin.database.ThenableReference; | ||
| remove(onComplete?: (a: Error|null) => any): Promise<void>; |
src/index.d.ts
Outdated
| update(values: Object, onComplete?: (a: Error|null) => any): Promise<void>; | ||
| } | ||
|
|
||
| interface ThenableReference extends admin.database.Reference, Promise<any> {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the old RTDB typings back until we figure out a more permanent solution with the JS SDK. Should resolve issues like #136