Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds @license JSDoc tag to license comments #1102

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

nathanmosher
Copy link
Contributor

Hi, just hoping to get this license tag submitted upstream to help this code play a bit better with the NodeJS import tools internally (at Google). The change will help a Google3 import script know that a comment block is, in fact, a license comment block.

There's a few trailing whitespaces my editor really wanted to remove too, lmk if I should revert them, and if you need more context.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@hiranya911
Copy link
Contributor

@lahirumaramba please merge this when ready. I don't think @nathanmosher has write access on this repo.

@lahirumaramba
Copy link
Member

@lahirumaramba please merge this when ready. I don't think @nathanmosher has write access on this repo.

Sounds good! I started the process.

@lahirumaramba lahirumaramba merged commit f624b29 into firebase:master Dec 3, 2020
BorntraegerMarc pushed a commit to BorntraegerMarc/firebase-admin-node that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants