Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter export missing from Firestore package #2191

Closed
jhuleatt opened this issue May 23, 2023 · 0 comments · Fixed by #2192
Closed

Filter export missing from Firestore package #2191

jhuleatt opened this issue May 23, 2023 · 0 comments · Fixed by #2192
Assignees

Comments

@jhuleatt
Copy link
Contributor

[REQUIRED] Step 2: Describe your environment

  • Operating System version: (any)
  • Firebase SDK version: 11.8.0
  • Firebase Product: Firestore
  • Node.js version: (any)
  • NPM version: (any)

[REQUIRED] Step 3: Describe the problem

For Firestore OR queries, the Firebase reference docs link out to the Cloud Firestore reference docs, which have this code snippet: https://googleapis.dev/nodejs/firestore/latest/Filter.html#.or

The example uses a Filter object. When I try to import that with const { getFirestore, Filter } = require('firebase-admin/firestore');, I get this error:

Module '"firebase-admin/firestore"' has no exported member 'Filter'.

After checking the exports for firebase-admin/firestore, it looks like the Filter re-export is missing:

export {
AddPrefixToKeys,
BulkWriter,
BulkWriterOptions,
BundleBuilder,
ChildUpdateFields,
CollectionGroup,
CollectionReference,
DocumentChange,
DocumentChangeType,
DocumentData,
DocumentReference,
DocumentSnapshot,
FieldPath,
FieldValue,
Firestore,
FirestoreDataConverter,
GeoPoint,
GrpcStatus,
NestedUpdateFields,
OrderByDirection,
PartialWithFieldValue,
Precondition,
Primitive,
Query,
QueryDocumentSnapshot,
QueryPartition,
QuerySnapshot,
ReadOptions,
ReadOnlyTransactionOptions,
ReadWriteTransactionOptions,
Settings,
SetOptions,
Timestamp,
Transaction,
UpdateData,
UnionToIntersection,
WhereFilterOp,
WithFieldValue,
WriteBatch,
WriteResult,
v1,
setLogFunction,
} from '@google-cloud/firestore';

Relevant Code:

const { getFirestore, Filter } = require('firebase-admin/firestore');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants