Authentication with e-mail link was not working in iOS13.

[rojo69]

The success alert got removed right away, without notifying the delegate.

Fixes #785

[morganchen12]

I think using key here is technically undefined behavior since key is uninitialized. Consider using a selector instead, or setting key to nil and using &key.

[rojo69]

Yes, you are correct. Will change it to the address of a static char.

…

3 okt. 2019 kl. 18:53 skrev Morgan Chen ***@***.***>:  @morganchen12 commented on this pull request. In Auth/FirebaseAuthUI/FUIAuthBaseViewController.m: > @@ -287,6 +288,15 @@ + (void)showAlertWithTitle:(nullable NSString *)title window.windowLevel = UIWindowLevelAlert + 1; [window makeKeyAndVisible]; [viewController presentViewController:alertController animated:YES completion:nil]; + + if ***@***.***(iOS 13.0, *)) { + /* + Earlier iOS versions established a strong reference to the window when makeKeyAndVisible was called. + Now we add one from the alert controller, to prevent objects from getting garbage collected right away. + */ + static void *key; + objc_setAssociatedObject(alertController, key, window, OBJC_ASSOCIATION_RETAIN_NONATOMIC); I think using key here is technically undefined behavior since key is uninitialized. Consider using a selector instead, or setting key to nil and using &key. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[morganchen12]

Thanks!