More Firebase 11 updates #1193
Merged
More Firebase 11 updates #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
Jul 24, 2024
| @@ -43,7 +43,8 @@ - (void)showDeleteAccountDialog { | |||
| alertMessage:FUILocalizedString(kStr_DeleteAccountBody) | |||
| alertCloseButton:FUILocalizedString(kStr_Cancel) | |||
| providerHandler:^(id<FIRUserInfo> provider) { | |||
| if (![provider.providerID isEqualToString:FIREmailAuthProviderID]) { | |||
| // TODO: Use public API after Firebase 11 minimum. | |||
| if (![provider.providerID isEqualToString:@"email"]) { | |||
There was a problem hiding this comment.
optional: Since this is across multiple files can you define a temporary module-level constant and put the TODO over that constant? Applies to the other strings as well.
Optional since these can all be found with code search.
There was a problem hiding this comment.
Going to skip this since it would require a separate header for each product or more rearchitecture of both build systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build from SPM with both Firebase 10 and Firebase 11
Migrate to GoogleSignIn 7. I disabled and left a TODO for the unit tests that need to be updated in
FirebaseGoogleAuthUITests/FirebaseGoogleAuthUITests.mThere are several ugly string changes because SPM does not include the libraries global string constants. (CocoaPods does).
Once the minimum dependency is Firebase 11, they can be updated to the Swift symbol.