Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FUIAuth.m #1012

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Update FUIAuth.m #1012

merged 1 commit into from
Jan 14, 2022

Conversation

kbot
Copy link
Contributor

@kbot kbot commented Nov 8, 2021

Prevent an error from being swallowed in the case of FIRAuthErrorCodeAccountExistsWithDifferentCredential when the emailAiuthProvider is nil.

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

  • Read the contribution guidelines.
  • If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
  • If this is a new feature please co-ordinate with someone on FirebaseUI-Android to make sure that we can implement this on both platforms and maintain feature parity.

Prevent an error from being swallowed in the case of FIRAuthErrorCodeAccountExistsWithDifferentCredential when the emailAiuthProvider is nil.
@google-cla
Copy link

google-cla bot commented Nov 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 8, 2021
@morganchen12
Copy link
Contributor

Hey @kbot, thanks for the contribution! Please sign the CLA, then we'll have someone review this PR.

@kbot
Copy link
Contributor Author

kbot commented Nov 8, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 8, 2021
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@morganchen12 morganchen12 merged commit 72a910a into firebase:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants