Skip to content

Commit

Permalink
Merge pull request #1024 from firebase/pb-v9-updates
Browse files Browse the repository at this point in the history
Update FirebaseUI for v8.x and v9.x compatibility
  • Loading branch information
morganchen12 authored Apr 14, 2022
2 parents 2319fad + d4ee46b commit 6c2993a
Show file tree
Hide file tree
Showing 18 changed files with 58 additions and 26 deletions.
4 changes: 2 additions & 2 deletions FirebaseAnonymousAuthUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseAnonymousAuthUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'Provides anonymous auth support for FirebaseAuthUI.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand All @@ -19,7 +19,7 @@ Pod::Spec.new do |s|
s.public_header_files = 'FirebaseAnonymousAuthUI/Sources/Public/FirebaseAnonymousAuthUI/*.h'
s.source_files = 'FirebaseAnonymousAuthUI/Sources/**/*.{h,m}'
s.dependency 'FirebaseAuthUI'
s.dependency 'FirebaseAuth', '~> 8.0'
s.dependency 'FirebaseAuth', '>= 8.0', '< 10.0'
s.dependency 'FirebaseCore'
s.resource_bundles = {
'FirebaseAnonymousAuthUI' => [
Expand Down
4 changes: 2 additions & 2 deletions FirebaseAuthUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseAuthUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'A prebuilt authentication UI flow for Firebase Auth.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand All @@ -18,7 +18,7 @@ Pod::Spec.new do |s|

s.public_header_files = 'FirebaseAuthUI/Sources/Public/FirebaseAuthUI/*.h'
s.source_files = 'FirebaseAuthUI/Sources/**/*.{h,m}'
s.dependency 'FirebaseAuth', '~> 8.0'
s.dependency 'FirebaseAuth', '>= 8.0', '< 10.0'
s.dependency 'FirebaseCore'
s.resource_bundles = {
'FirebaseAuthUI' => ['FirebaseAuthUI/Sources/{Resources,Strings}/*.{xib,png,lproj}']
Expand Down
4 changes: 2 additions & 2 deletions FirebaseDatabaseUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseDatabaseUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'Prebuilt data sources and UI bindings for Firebase Database.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand All @@ -18,6 +18,6 @@ Pod::Spec.new do |s|

s.public_header_files = 'FirebaseDatabaseUI/Sources/Public/FirebaseDatabaseUI/*.h'
s.source_files = 'FirebaseDatabaseUI/Sources/**/*.{h,m}'
s.dependency 'FirebaseDatabase', '~> 8.0'
s.dependency 'FirebaseDatabase', '>= 8.0', '< 10.0'

end
2 changes: 1 addition & 1 deletion FirebaseEmailAuthUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseEmailAuthUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'An email authentication provider for FirebaseAuthUI.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand Down
2 changes: 1 addition & 1 deletion FirebaseFacebookAuthUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseFacebookAuthUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'A Facebook auth provider for FirebaseAuthUI.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand Down
4 changes: 2 additions & 2 deletions FirebaseFirestoreUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseFirestoreUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'Data libraries and UI bindings for Firestore.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand All @@ -18,6 +18,6 @@ Pod::Spec.new do |s|

s.public_header_files = 'FirebaseFirestoreUI/Sources/Public/FirebaseFirestoreUI/*.h'
s.source_files = 'FirebaseFirestoreUI/Sources/**/*.{h,m}'
s.dependency 'FirebaseFirestore', '~> 8.0'
s.dependency 'FirebaseFirestore', '>= 8.0', '< 10.0'

end
2 changes: 1 addition & 1 deletion FirebaseGoogleAuthUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseGoogleAuthUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'Google authentication for FirebaseAuthUI.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand Down
4 changes: 2 additions & 2 deletions FirebaseOAuthUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseOAuthUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'A collection of OAuth providers for FirebaseAuthUI.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand All @@ -19,7 +19,7 @@ Pod::Spec.new do |s|
s.public_header_files = 'FirebaseOAuthUI/Sources/Public/FirebaseOAuthUI/*.h'
s.source_files = 'FirebaseOAuthUI/Sources/**/*.{h,m}'
s.dependency 'FirebaseAuthUI', '>= 12.0.2', '< 13.0'
s.dependency 'FirebaseAuth', '~> 8.0'
s.dependency 'FirebaseAuth', '>= 8.0', '< 10.0'
s.resource_bundles = {
'FirebaseOAuthUI' => ['FirebaseOAuthUI/Sources/{Resources,Strings}/*.{png,lproj}']
}
Expand Down
2 changes: 1 addition & 1 deletion FirebasePhoneAuthUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebasePhoneAuthUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'A phone auth provider for FirebaseAuthUI.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand Down
4 changes: 2 additions & 2 deletions FirebaseStorageUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseStorageUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'UI binding libraries for Firebase.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand All @@ -20,7 +20,7 @@ Pod::Spec.new do |s|
s.tvos.deployment_target = '11.0'
s.public_header_files = 'FirebaseStorageUI/Sources/Public/FirebaseStorageUI/*.h'
s.source_files = 'FirebaseStorageUI/Sources/**/*.{h,m}'
s.dependency 'FirebaseStorage', '~> 8.0'
s.dependency 'FirebaseStorage', '>= 8.0', '< 10.0'
s.dependency 'SDWebImage', '~> 5.6'

end
12 changes: 9 additions & 3 deletions FirebaseStorageUI/Sources/FUIStorageImageLoader.m
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,13 @@
#import "FirebaseStorageUI/Sources/Public/FirebaseStorageUI/FIRStorageDownloadTask+SDWebImage.h"

#import <FirebaseCore/FirebaseCore.h>
#import <FirebaseStorage/FirebaseStorage.h>
#if __has_include(<FirebaseStorage/FirebaseStorage.h>)
// Firebase 8.x
#import <FirebaseStorage/FirebaseStorage.h>
#else
// Firebase 9.0+
#import <FirebaseStorage/FirebaseStorage-Swift.h>
#endif

#if SWIFT_PACKAGE
@import GTMSessionFetcherCore;
Expand Down Expand Up @@ -120,7 +126,7 @@ - (BOOL)canRequestImageForURL:(NSURL *)url {
[download observeStatus:FIRStorageTaskStatusProgress handler:^(FIRStorageTaskSnapshot * _Nonnull snapshot) {
// Check progressive decoding if need
if (options & SDWebImageProgressiveLoad) {
FIRStorageDownloadTask *task = snapshot.task;
FIRStorageDownloadTask *task = (FIRStorageDownloadTask *)snapshot.task;
// Currently, FIRStorageDownloadTask does not have the API to grab partial data
// But since FirebaseUI and Firebase are seamless component, we access the internal fetcher here
GTMSessionFetcher *fetcher = task.fetcher;
Expand Down Expand Up @@ -160,7 +166,7 @@ - (BOOL)canRequestImageForURL:(NSURL *)url {
}

- (BOOL)shouldBlockFailedURLWithURL:(NSURL *)url error:(NSError *)error {
if ([error.domain isEqualToString:FIRStorageErrorDomain]) {
if ([error.domain isEqualToString:@"FIRStorageErrorDomain"]) {
if (error.code == FIRStorageErrorCodeBucketNotFound
|| error.code == FIRStorageErrorCodeProjectNotFound
|| error.code == FIRStorageErrorCodeObjectNotFound) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@
// limitations under the License.
//

#import <FirebaseStorage/FirebaseStorage.h>
#if __has_include(<FirebaseStorage/FirebaseStorage.h>)
// Firebase 8.x
#import <FirebaseStorage/FirebaseStorage.h>
#else
// Firebase 9.0+
#import <FirebaseStorage/FirebaseStorage-Swift.h>
#endif
#import <SDWebImage/SDWebImage.h>

NS_ASSUME_NONNULL_BEGIN
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@
// limitations under the License.
//

#import <FirebaseStorage/FirebaseStorage.h>
#if __has_include(<FirebaseStorage/FirebaseStorage.h>)
// Firebase 8.x
#import <FirebaseStorage/FirebaseStorage.h>
#else
// Firebase 9.0+
#import <FirebaseStorage/FirebaseStorage-Swift.h>
#endif
#import <SDWebImage/SDWebImage.h>

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,14 @@
// limitations under the License.
//
#import <Foundation/Foundation.h>
#import <FirebaseStorage/FirebaseStorage.h>

#if __has_include(<FirebaseStorage/FirebaseStorage.h>)
// Firebase 8.x
#import <FirebaseStorage/FirebaseStorage.h>
#else
// Firebase 9.0+
#import <FirebaseStorage/FirebaseStorage-Swift.h>
#endif

NS_ASSUME_NONNULL_BEGIN

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@

#import <UIKit/UIKit.h>

#import <FirebaseStorage/FirebaseStorage.h>
#if __has_include(<FirebaseStorage/FirebaseStorage.h>)
// Firebase 8.x
#import <FirebaseStorage/FirebaseStorage.h>
#else
// Firebase 9.0+
#import <FirebaseStorage/FirebaseStorage-Swift.h>
#endif
#import <SDWebImage/SDWebImage.h>

NS_ASSUME_NONNULL_BEGIN
Expand Down
2 changes: 1 addition & 1 deletion FirebaseUI.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseUI'
s.version = '12.1.1'
s.version = '12.2.0'
s.summary = 'UI binding libraries for Firebase.'
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ let package = Package(
.package(
name: "Firebase",
url: "https://github.com/firebase/firebase-ios-sdk.git",
from: "8.0.0"
"8.0.0"..<"10.0.0"
),
.package(
name: "GoogleSignIn",
Expand Down
3 changes: 2 additions & 1 deletion samples/objc/FirebaseUI-demo-objc/FUIAppDelegate.m
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@

#import "FUIAppDelegate.h"

@import Firebase;
@import FirebaseCore;
@import FirebaseAuthUI;
@import FirebaseDynamicLinks;
@import FBSDKCoreKit;
#import <GTMSessionFetcher/GTMSessionFetcherLogging.h>

Expand Down

0 comments on commit 6c2993a

Please sign in to comment.