AT-79: Add style generation for Lit #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninopenttinen
requested changes
Sep 12, 2023
rooperl
commented
Sep 13, 2023
esbuild doesn't currently support tree-shaking namespaced wildcard exports such as the following: export * as FdsCss from './style-properties'
This will tell bundlers such as esbuild that calling unsafeCSS has no side effects when such import is unused
… -> Fds in exported names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokens.jsontokenVarfrom coreui-components and export it fromlib(see AT-79: Use Lit styles and tokenVar function from coreui-css fds-coreui-components#39)