Fix http error decorator #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daleal
approved these changes
Oct 7, 2024
vnazar
force-pushed
the
fix/fix-http-error-decorator
branch
from
ae474af to
8a6d8f2
Compare
vnazar
force-pushed
the
fix/fix-http-error-decorator
branch
from
8a6d8f2 to
4c3041d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Este PR permite obtener los mensajes de error de la librería
httpxcuando no son de tipohttpx.HTTPStatusError. Hasta el momento solo se atrapaba el errorhttpx.HTTPError, pero este era poco específico y fallaba cuando el error traía el atributo.response(el cual solo tienehttpx.HTTPStatusError).Requirements
None.
Additional changes
can_raise_http_erroracan_raise_fintoc_error, ya que es más correcto.