Use fmt header only

fintarin · Apr 28, 2024 · 740d107 · 740d107
1 parent 7d7f792
commit 740d107
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -47,7 +47,7 @@ target_include_directories(
 
 target_link_libraries(
   ${PROJECT_NAME}
-  PUBLIC fmt::fmt
+  PUBLIC fmt::fmt-header-only
          cppcoro
          MPFR
          Boost::multiprecision

diff --git a/src/fintamath/numbers/RealFunctions.cpp b/src/fintamath/numbers/RealFunctions.cpp
@@ -173,7 +173,9 @@ catch (const UndefinedException &exc) {
 }
 
 Real log(const Real &lhs, const Real &rhs) try {
-  return ln(rhs) / ln(lhs);
+  Real divLhs = ln(rhs);
+  Real divRhs = ln(lhs);
+  return divLhs / divRhs;
 }
 catch (const UndefinedException &exc) {
   throw UndefinedException(fmt::format(

diff --git a/tests/src/numbers/RealFunctionsTests.cpp b/tests/src/numbers/RealFunctionsTests.cpp
@@ -579,11 +579,11 @@ TEST(RealFunctionsTests, logTest) {
   EXPECT_THAT(
       [] { log(Real("0"), Real("-0")); },
       testing::ThrowsMessage<UndefinedException>(
-          testing::StrEq("log(0.0, -0.0) is undefined (ln(0.0) is undefined (expected argument > 0))")));
+          testing::StrEq("log(0.0, -0.0) is undefined (ln(-0.0) is undefined (expected argument > 0))")));
   EXPECT_THAT(
       [] { log(Real("-0"), Real("0")); },
       testing::ThrowsMessage<UndefinedException>(
-          testing::StrEq("log(-0.0, 0.0) is undefined (ln(-0.0) is undefined (expected argument > 0))")));
+          testing::StrEq("log(-0.0, 0.0) is undefined (ln(0.0) is undefined (expected argument > 0))")));
   EXPECT_THAT(
       [] { log(Real("-0"), Real("-0")); },
       testing::ThrowsMessage<UndefinedException>(

diff --git a/thirdparty/CMakeLists.txt b/thirdparty/CMakeLists.txt
@@ -18,7 +18,7 @@ set(CMAKE_MODULE_PATH
     PARENT_SCOPE)
 
 add_subdirectory(fmt)
-suppress_warnings(fmt)
+suppress_warnings(fmt-header-only)
 
 add_subdirectory(cppcoro)
 suppress_warnings(cppcoro)