generated from finos-labs/project-blueprint
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate bitemporal SQL reporting service (Tech Sprint 2024) #237
Draft
refset
wants to merge
96
commits into
finos:main
Choose a base branch
from
xtdb:bitemporal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: pass on the price to trade blotter and position and persist trades in XTDB
consider if all prices or only those asked for
use styles to highlite background for gain/loss
Fetch data on slider release
To prevent horizontal scrolling
✅ Deploy Preview for lucky-concha-f3599f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Draft PR presents a set of changes delivered as part of JUXT's involvement with the Tech Sprint. The changes may be reviewed, discussed and considered for upstream usage as desired.
The changes are documented in this README.
However, based on recent discussions with key community members, it sounds likely that the ultimate approach to integrating the bulk of these changes (if at all) will depend on there first being some 'knowledge graph' strategy implemented within this repo.
Please advise if there are obvious changes we could make to aid with reviewing/assessing/discussing, thanks.