Minor fixes and tidy-ups

finos · Oct 31, 2024 · 7a7fa49 · 7a7fa49
1 parent 4601905
commit 7a7fa49
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/tracdap-api/tracdap-metadata/src/main/proto/tracdap/metadata/job.proto b/tracdap-api/tracdap-metadata/src/main/proto/tracdap/metadata/job.proto
@@ -197,7 +197,7 @@ message ExportDataJob {
  * Specify the group type for a JOB_GROUP job
  */
 enum JobGroupType {
-  EMPTY_JOB_GROUP = 0;
+  JOB_GROUP_TYPE_NOT_SET = 0;
   SEQUENTIAL_JOB_GROUP = 1;
   PARALLEL_JOB_GROUP = 2;
 }

diff --git a/tracdap-runtime/python/src/tracdap/rt/_exec/dev_mode.py b/tracdap-runtime/python/src/tracdap/rt/_exec/dev_mode.py
@@ -199,7 +199,7 @@ def translate_job_group(
 
         job_group = job_def.jobGroup
 
-        if job_group.jobGroupType is None or job_group.jobGroupType == _meta.JobGroupType.EMPTY_JOB_GROUP:
+        if job_group.jobGroupType is None or job_group.jobGroupType == _meta.JobGroupType.JOB_GROUP_TYPE_NOT_SET:
             job_group = self._process_job_group_type(job_group)
 
         group_details = self._get_job_group_detail(job_group)

diff --git a/tracdap-runtime/python/src/tracdap/rt/_exec/functions.py b/tracdap-runtime/python/src/tracdap/rt/_exec/functions.py
@@ -715,7 +715,7 @@ def __init__(self, node: ChildJobNode):
 
     def _execute(self, ctx: NodeContext):
         # This node should never execute, the engine intercepts child job nodes and provides special handling
-        raise _ex.ETracInternal("Child job was not processed correctly(this is a bug)")
+        raise _ex.ETracInternal("Child job was not processed correctly (this is a bug)")
 
 
 

diff --git a/tracdap-runtime/python/src/tracdap/rt/_exec/graph.py b/tracdap-runtime/python/src/tracdap/rt/_exec/graph.py
@@ -20,6 +20,7 @@
 import tracdap.rt.metadata as meta
 import tracdap.rt.config as cfg
 
+
 _T = tp.TypeVar('_T')
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,6 +20,7 @@
		import tracdap.rt.metadata as meta
		import tracdap.rt.config as cfg


		_T = tp.TypeVar('_T')


Expand Down