Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github actions to use newer node #2619

Closed
wants to merge 1 commit into from
Closed

Bump github actions to use newer node #2619

wants to merge 1 commit into from

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented May 16, 2024

We are currently using some older GitHub actions that raise deprecation warnings, to avoid disruption to CI this PR upgrades them to newer versions.

Screenshot 2024-05-16 at 09 20 53

This PR also limits the node upper bound to 22 to avoid the assert { type: "json" } / with { type: "json" } change (proposal here tc39/proposal-import-attributes#131 ) which affects Node 22.

@texodus
Copy link
Member

texodus commented May 16, 2024

avoid assert { type: "json" } / with { type: "json" } change
tc39/proposal-import-attributes#131

Signed-off-by: Tim Paine <[email protected]>
@texodus
Copy link
Member

texodus commented May 19, 2024

I've cherry-picked this into #2623, as this needs rebasing and a new set of branch protections for the new box names, closing.

@texodus texodus closed this May 19, 2024
@timkpaine timkpaine deleted the tkp/node22 branch July 4, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants