Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Commit for the Starting Point of Calm Hub #709

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Initial Commit for the Starting Point of Calm Hub #709

merged 3 commits into from
Jan 1, 2025

Conversation

jpgough-ms
Copy link
Member

No description provided.

@jpgough-ms
Copy link
Member Author

This will fix #543 - once merged, a batch of new issues will be created for upcoming changes/enhancements/improvements for Calm Hub

rocketstack-matt
rocketstack-matt approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@rocketstack-matt rocketstack-matt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, the only issue is that I can't follow the quick start instructions from Mac Silicon, but running the local dev mode to startup a local mongo instance and building the server and UI locally works great.

Will approve, although suggest we make a comment in the README about the limitation until we support other architectures.

@jpgough-ms jpgough-ms mentioned this pull request Jan 1, 2025
Closed
@jpgough-ms
Copy link
Member Author

This looks good, the only issue is that I can't follow the quick start instructions from Mac Silicon, but running the local dev mode to startup a local mongo instance and building the server and UI locally works great.

Will approve, although suggest we make a comment in the README about the limitation until we support other architectures.

I’m going to merge, but will address these issues tomorrow

@jpgough-ms jpgough-ms merged commit 88a295d into finos:main Jan 1, 2025
8 of 9 checks passed
@jpgough-ms jpgough-ms deleted the calm-hub branch January 1, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketstack-matt rocketstack-matt rocketstack-matt approved these changes

@aidanm3341 aidanm3341 Awaiting requested review from aidanm3341 aidanm3341 is a code owner

@lbulanti-ms lbulanti-ms Awaiting requested review from lbulanti-ms lbulanti-ms is a code owner

@willosborne willosborne Awaiting requested review from willosborne willosborne is a code owner

@grahampacker-ms grahampacker-ms Awaiting requested review from grahampacker-ms grahampacker-ms is a code owner

@Thels Thels Awaiting requested review from Thels Thels is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpgough-ms @rocketstack-matt