Added toggle to hide/show node descriptions #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oliviajanejohns
commented
Dec 20, 2024
oliviajanejohns
commented
- Tidied up styling of navbar
- Added additional toggle to show/hide node descriptions
- Setup vitest
oliviajanejohns
requested review from
aidanm3341,
lbulanti-ms,
willosborne,
grahampacker-ms,
jpgough-ms,
rocketstack-matt,
Thels and
a team
as code owners
oliviajanejohns
commented
Dec 20, 2024
| @@ -151,15 +152,14 @@ function Drawer({ calmInstance, title, isDescActive }: DrawerProps) { | |||
| return { | |||
| data: { | |||
| id: relationship['unique-id'], | |||
| label: (isDescActive && relationship.description) || '', | |||
| label: relationship.description || '', | |||
There was a problem hiding this comment.
Required to pass in descriptions to sidebar
oliviajanejohns
force-pushed
the
explore-cytoscape
branch
from
4d2a149 to
77057af
Compare
LeighFinegold
approved these changes
Dec 24, 2024
oliviajanejohns
merged commit da26d35
into
finos:explore-cytoscape
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.