Added group and nested group functionality #564
Conversation
| relationship =>{ | ||
| const connects = relationship["relationship-type"]["connects"]; | ||
| instance.connect({ | ||
| source: document.getElementById(connects.source.node)!, |
There was a problem hiding this comment.
Seeing getElementById in a React site gives me pause. I'm not a React dev but is there a better way to look this up?
@aidanm3341 might be good to get your thoughts here?
There was a problem hiding this comment.
this is my bad for doing it the quick and dirty way on the hackday. There is a better way using react ref's instead, but I don't think it should be a blocker for this PR. It would be good for us to refactor this before merging into main though
|
a general question - how does the dragging around of elements work with the groups? Are the nodes limited to the bounds of the container? Or can they move around freely? |
|
For the containers nodes, we should also give them a dashed outline instead of the solid colour one and make it a subtler grey colour |
The nodes are limited to the bounds of its container |
|
|
|
|
|
Implement functionality to create groups based on “deployed in” and “composed of” relationships.
Note: Additional logic is required to dynamically adjust the size of group containers to fit the nodes they encompass.