fix: Upgrade master to 6.x #795
Conversation
…778) * update mac build script * update mac packager * feat: ELECTRON-1462 (Combine more information into about app window) (#777) * ELECTRON-1462 - Merge more info window in to about app window * ELECTRON-1462 - Adjust window size * ELECTRON-1462 - Add line space * ELECTRON-1462 - Resize for windows * ELECTRON-1462 - Add translation for swift search * ELECTRON-1462 - Adjust width for Windows OS * ELECTRON-1462 - Add about app snapshots file * SDA-1347 - Group multiple processes into single task bar icon
# Conflicts: # package.json
KiranNiranjan
requested review from
keerthi16,
VishwasShashidhar and
johankwarnmarksymphony
| "jest": "23.6.0", | ||
| "jest-html-reporter": "2.4.2", | ||
| "less": "3.8.1", | ||
| "node-abi": "^2.12.0", |
There was a problem hiding this comment.
please freeze the version number here.
There was a problem hiding this comment.
We always need the latest version of node-abi when we upgrade the electron version for the native module to compile
src/common/logger.ts
Outdated
| // Default log paths | ||
| const MAC_LOGS_PATH = '/Library/Logs/Symphony/'; | ||
| const LINUX_LOGS_PATH = '/.config/Symphony/'; | ||
| const WINDOWS_LOGS_PATH = '\\AppData\\Roaming\\Symphony\\logs'; |
There was a problem hiding this comment.
please change this to AppData\\Local as we are making changes accordingly.
There was a problem hiding this comment.
The default location for logs in 6.x+ has defaulted to userData path
There was a problem hiding this comment.
Yes, understood. But, we need to override that now to point to local rather than roaming.
Electron by default picks roaming for user data path rather than local which we need to override now.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Merge 6.x branch into master
Fixes
electron-spellcheckermodule to support 6.xelectron-buildermodule to support 6.x