-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a homebrew target for easy install on macs #22
Conversation
Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@yschimke). In order for your PR to be reviewed and merged, please follow the directions at the link above. Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above. If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin |
Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@yschimke). In order for your PR to be reviewed and merged, please follow the directions at the link above. Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above. If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin |
CLA has been signed |
@finos-cla-bot[bot] check |
The cla-bot has been summoned, and re-checked this pull request! |
@yschimke , you're now registered as FINOS Contributor. Thanks. |
jcurl.rb
Outdated
(bin/"jcurl").write <<~EOS | ||
#!/bin/sh | ||
|
||
java -jar #{prefix}/jcurl.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix an embarrassing bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! LGTM
Ideally this would live at https://github.com/symphonyoss/homebrew-tap/jcurl.rb but I can't submit a PR to that location
With that structure it would be installable via
brew install symphonyoss/tap/jcurl
To test current file use
brew install jcurl.rb