Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a homebrew target for easy install on macs #22

Merged
merged 3 commits into from
Sep 17, 2018
Merged

Add a homebrew target for easy install on macs #22

merged 3 commits into from
Sep 17, 2018

Conversation

yschimke
Copy link
Contributor

@yschimke yschimke commented Sep 12, 2018

Ideally this would live at https://github.com/symphonyoss/homebrew-tap/jcurl.rb but I can't submit a PR to that location

With that structure it would be installable via

brew install symphonyoss/tap/jcurl

To test current file use brew install jcurl.rb

@finos-admin
Copy link
Member

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@yschimke). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

@finos-admin
Copy link
Member

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@yschimke). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

@yschimke
Copy link
Contributor Author

CLA has been signed

@maoo
Copy link
Member

maoo commented Sep 15, 2018

@finos-cla-bot[bot] check

@finos-admin
Copy link
Member

The cla-bot has been summoned, and re-checked this pull request!

@maoo
Copy link
Member

maoo commented Sep 15, 2018

@yschimke , you're now registered as FINOS Contributor. Thanks.

jcurl.rb Outdated
(bin/"jcurl").write <<~EOS
#!/bin/sh

java -jar #{prefix}/jcurl.jar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix an embarrassing bug

Copy link
Contributor

@ldrozdz ldrozdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! LGTM

@ldrozdz ldrozdz merged commit 6cb2551 into finos:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants