Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Bump FinniversKit - radio button and checkboxes aren't animated anymore #141

Merged
merged 4 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ let package = Package(
),
],
dependencies: [
.package(url: "https://github.com/finn-no/FinniversKit.git", "128.0.0"..."999.0.0")
.package(url: "https://github.com/finn-no/FinniversKit.git", branch: "checkbox-radiobutton-update")//"128.0.0"..."999.0.0")
],
targets: [
.target(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ extension ProjectUnitsListView.SortView: UITableViewDelegate {
else { return }

sortOptions[indexPath.row].isSelected = true
cell.animateSelection(isSelected: true)
cell.configure(isSelected: true)
impactGenerator.impactOccurred()
delegate?.sortView(self, didSelectSortOption: sortOptions[indexPath.row].column)
}
Expand All @@ -81,7 +81,7 @@ extension ProjectUnitsListView.SortView: UITableViewDelegate {
}

sortOptions[indexPath.row].isSelected = false
cell.animateSelection(isSelected: false)
cell.configure(isSelected: false)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class QuestionItemView: UIView {
// MARK: - Private properties

private weak var delegate: QuestionItemViewDelegate?
private lazy var checkbox = AnimatedCheckboxView(frame: .zero)
private lazy var checkbox = CheckboxView()

private lazy var stackView: UIStackView = {
let stackView = UIStackView(axis: .horizontal, spacing: .spacingXS, withAutoLayout: true)
Expand Down Expand Up @@ -56,8 +56,8 @@ class QuestionItemView: UIView {
// MARK: - Internal methods

func updateView() {
if question.isSelected != checkbox.isHighlighted {
checkbox.animateSelection(selected: question.isSelected)
if question.isSelected != checkbox.isSelected {
checkbox.configure(isSelected: question.isSelected)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class UserContactMethodSelectionView: UIView {

let viewModel: UserContactMethodSelectionModel
private weak var delegate: UserContactMethodSelectionViewDelegate?
private lazy var radioButton = AnimatedRadioButtonView(frame: .zero)
private lazy var radioButton = RadioButtonView()

private lazy var stackView: UIStackView = {
let stackView = UIStackView(axis: .horizontal, spacing: .spacingXS, withAutoLayout: true)
Expand Down Expand Up @@ -52,7 +52,7 @@ class UserContactMethodSelectionView: UIView {
// MARK: - Internal methods

func updateView() {
radioButton.animateSelection(selected: !radioButton.isHighlighted)
radioButton.configure(isSelected: !radioButton.isHighlighted)
}

// MARK: - Actions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/finn-no/FinniversKit.git",
"state" : {
"revision" : "1cc6d480f1805aeeac511080f810291af411d300",
"version" : "128.0.0"
"branch" : "checkbox-radiobutton-update",
"revision" : "e291c055f335eb88614629334bb9064b04eac229"
}
},
{
Expand All @@ -26,6 +26,15 @@
"revision" : "b44b563e6ddc5a613a107fb57626047a7f1d4e1a",
"version" : "1.9.666"
}
},
{
"identity" : "warp-ios",
"kind" : "remoteSourceControl",
"location" : "https://github.com/warp-ds/warp-ios.git",
"state" : {
"revision" : "7d24900acc6225655038c7ea5e3e9f9249631d58",
"version" : "0.0.3"
}
}
],
"version" : 2
Expand Down