This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Refactor: Use DemoKit #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstien
requested review from
a team,
AndreyMomot and
robinsalehjan
and removed request for
a team
BjornRuud
approved these changes
Jul 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
As mentioned in this sibling PR in FinniversKit we have a new library for demo/snapshotting named DemoKit.
I've added one new thing to DemoKit after that PR:
ViewControllerAccessor. One of the demos need to be able to present aBottomSheetin order to select sorting, so this protocol will give access to the wrapping viewController for aDemoable.To keep things tidy, since I saw that the FinniversKit PR got overwhelming, I've only included changes needed for the demo in this PR. I'll create a separate one for snapshots. This means this PR will fail badly on CircleCI.
What?
Version Change
Patch. No API changes to FinnUI.
UI Changes
See the gif in the FinniversKit PR: finn-no/FinniversKit#1237