fix-prevent-frequent-state-change-on-api-glitch #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #70.
Addresses momentary inability of the NWS Alerts API to respond with valid data, which is a frequent occurrence. When this happens, the entity from the integration becomes unavailable, which can cause unnecessary and annoying alert notifications in some HA installations.
The suggested fix is to NOT update the entity's state when this error occurs. All other behavior remains unchanged, including the reporting of all other types of errors.
If the API remains in this failed state for an extended period of time, the data in the entity can become stale. However, I believe it is better to present the latest available alert data, rather than no data at all.
As to the type of log message reported, this is such a frequent issue with no action necessary on the part of the user that after some reflection, I decided to log it as type
debug.