Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularise main script and add missing alt attributes to images #1806

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Modularise main script and add missing alt attributes to images #1806

merged 2 commits into from
Oct 1, 2022

Conversation

prajwalkulkarni
Copy link
Contributor

Problem

  • Lengthy contributors array makes the codebase unnecessarily large.

Solution

Changes proposed in this Pull Request :

  • Convert the main script to a module.
  • Move contributor's data separate module.
  • Add missing alt attributes to img tags.

@prajwalkulkarni prajwalkulkarni mentioned this pull request Oct 1, 2022
Closed
@fineanmol fineanmol added enhancement New feature or request hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Oct 1, 2022
@fineanmol fineanmol merged commit 14d901c into fineanmol:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing alt attribute in image tag & code refactoring
2 participants
@prajwalkulkarni @fineanmol