Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design FIX Improvement Needed in Contribition.html #189

Closed
fineanmol opened this issue Oct 1, 2021 · 13 comments
Closed

Design FIX Improvement Needed in Contribition.html #189

fineanmol opened this issue Oct 1, 2021 · 13 comments
Assignees
Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later

Comments

@fineanmol
Copy link
Owner

fineanmol commented Oct 1, 2021

Hello Guys, New Approach or designs are appreciated in Contribution.html
Preview here

Example:

  • Grid View needs to be Added
  • The dark theme and Light theme colors can be modified, Texts are not visible.
  • Card designs can be improved.
@fineanmol fineanmol added enhancement New feature or request help wanted Extra attention is needed hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Oct 1, 2021
@SukritSethi
Copy link
Contributor

Hi, I am pretty new to web dev. But I think I can pull this off in 3-4 days. Could u assign me with the dark theme task of the page.

@fineanmol
Copy link
Owner Author

Hi @SukritSethi , We are glad you want to contribute in this repo. Please fork this repo, made your changes and make a pull request.
We would love to see your work !

@RahulRudra81
Copy link
Contributor

I am too a newbie but I think I could pull this off and also learn some good stuff . Can I work on this?

@fineanmol
Copy link
Owner Author

I am too a newbie but I think I could pull this off and also learn some good stuff . Can I work on this?

Yes Please, Do your contributions and pull a request.

@Naman-pokhriyal
Copy link
Contributor

I think the hover transition, card size, theme switch and few other things can be better. Can I work on this?

@fineanmol
Copy link
Owner Author

I think the hover transition, card size, theme switch and few other things can be better. Can I work on this?

Yes Naman, Please show you magic ✨

@tuminzee
Copy link
Contributor

tuminzee commented Oct 2, 2021

Hello I think a rounded image of our GitHub avatar would be more suitable for the page.
Please tell me what you think about it.

image

@fineanmol
Copy link
Owner Author

Hello I think a rounded image of our GitHub avatar would be more suitable for the page. Please tell me what you think about it.

image

Yes, Its looking lovely

@tuminzee
Copy link
Contributor

tuminzee commented Oct 2, 2021

Hello I think a rounded image of our GitHub avatar would be more suitable for the page. Please tell me what you think about it.
image

Yes, Its looking lovely

#389

fineanmol added a commit that referenced this issue Oct 2, 2021
@fineanmol
Copy link
Owner Author

Hello I think a rounded image of our GitHub avatar would be more suitable for the page. Please tell me what you think about it.
image

Yes, Its looking lovely

#389

Hi @tuminzee , Layout of the CSS has been conflicted, List view needs to be shown in Grid. Please try to contribute there.

@fineanmol fineanmol changed the title Design Improvement Needed in Contribition.html Design FIX Improvement Needed in Contribition.html Oct 3, 2021
@RahulRudra81
Copy link
Contributor

@fineanmol I added my name in the contributors list and you merged it 2days ago but I can't see my name there now !! Can I add it again??

@fineanmol
Copy link
Owner Author

@fineanmol I added my name in the contributors list and you merged it 2days ago but I can't see my name there now !! Can I add it again??

Yes please. Maybe some other contributor removed your name by mistake.

@fineanmol fineanmol removed enhancement New feature or request help wanted Extra attention is needed labels Oct 5, 2021
@swatisingh46
Copy link

Can you assign this issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Development

No branches or pull requests

6 participants