Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RedundantInterfaces Serializable if check #49

Merged
merged 1 commit into from
Nov 15, 2015
Merged

Fix RedundantInterfaces Serializable if check #49

merged 1 commit into from
Nov 15, 2015

Conversation

vanniktech
Copy link
Contributor

The interface name comes with dots and not slashes.

@amaembo
Copy link
Contributor

amaembo commented Oct 2, 2015

Please add to findBugsTestCases a test case which failes without your fix, but succeeds with it. You may name your test as /findbugsTestCases/src/java/ghIssues/Issue0049.java. Use edu.umd.cs.findbugs.annotations.NoWarning and/or edu.umd.cs.findbugs.annotations.ExpectWarning annotations.

@vanniktech
Copy link
Contributor Author

@amaembo sorry it took me that long. I added a test file. Though I don't know how to run the tests or if it's even in the right format.

public static class SuperClass implements TestInterface {}

@ExpectWarning("RI_REDUNDANT_INTERFACES")
public static class SubClassWithDuplicate implements TestInterface {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this test: why public static class SuperClass implements TestInterface {} should not produce the warning, but public static class SubClassWithDuplicate implements TestInterface {} should produce? What's the difference between these two?

@vanniktech
Copy link
Contributor Author

@amaembo you're right. I forgot to subclass. Now the tests should make sense. I also squashed the commits together into one.

@amaembo amaembo merged commit 46c50ab into findbugsproject:master Nov 15, 2015
amaembo added a commit that referenced this pull request Nov 15, 2015
@amaembo
Copy link
Contributor

amaembo commented Nov 15, 2015

Merged, thanks.

@vanniktech vanniktech deleted the master_reduntantinterfaces_fix branch November 15, 2015 15:43
sebasjm pushed a commit to sebasjm/findbugs that referenced this pull request Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants