Fixing Missing load()
#33
Conversation
* Adding missing `load()` for `maybe()`.
|
Sorry for overlooking this. 😅 |
|
What worries me now is that it is broken, and yet it passed the presubmit checks. What gives? |
|
Well, I noticed this weekend that there was no CI running. I didn't think too much of it at first, but then this happened. Looking at the PR list, it shows that CI ran for all the old PRs but not the last 2. The last CI ran was on my last PR in March. So something is definitely broken with GH just running CI. |
|
I think I found it (maybe). I can't see this issue on this repo, because I'm not the/an owner. But, on my fork of this repo, I see that Actions are disabled. Going to the Actions tab, I see: So this seems like some sort of new change on GH to just disable all CI checking on low activity repos (which seems, y'know, dumb lol). |
|
Turns out the workflows were disabled for inactivity. Which kind of makes sense since it's a low activity repo. I just forgot that this happened. I re-enabled the workflows. |
|
OK, so this change still resulted in a broken post-submit. Sorry for the confusion around workflows. |
Np. Sorry about these breaking changes. I can send a PR to try and fix this, if you'd like. (I think its the change to |
|
Yes, please.
I think we should just use the regular link to the release archves such as
https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz,
vs the more "exotic" one. Unless I'm missing something?
F
…On Sat, May 11, 2024 at 11:58 PM CauhxMilloy ***@***.***> wrote:
OK, so this change still resulted in a broken post-submit. Sorry for the
confusion around workflows.
Np. Sorry about these breaking changes. I can send a PR to try and fix
this, if you'd like. (I think its the change to bazel_skylib repo).
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4GMCYIKZTX2LEG3IR4CDZB4HITAVCNFSM6AAAAABHSNOAKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGE2DGMJXHE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
It was just a missing I really wish GitHub would put a notice on PRs to warn about the disabled CI instead of silently letting anything through. Sorry again for all this. |
|
Well I did get a notification that the workflows would be disabled. But I have other things to do besides babysit github, so it fell by the wayside... :/ Now that I know what it means, I will take better care in the future. |
load()formaybe().