Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bats_test_suite rule #18

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Add bats_test_suite rule #18

merged 2 commits into from
Feb 27, 2023

Conversation

fmorency
Copy link
Contributor

The rule can generate bats_test targets for each source file and a test_suite, which encapsulates all tests.

With this rule, one can write a single test suite encapsulating all tests from a source while still being able to run the individual tests.

The rule can be used to generate `bats_test` targets for each source
file and a `test_suite` which encapsulates all tests.
rules.bzl Outdated Show resolved Hide resolved
@fmorency fmorency requested a review from filmil February 24, 2023 21:40
@filmil filmil merged commit e85b43e into filmil:master Feb 27, 2023
@fmorency fmorency deleted the bats_test_suite branch February 28, 2023 13:56
@fmorency
Copy link
Contributor Author

@filmil Thank you for merging this PR. Would it be possible to cut a new release with this change?

@filmil
Copy link
Owner

filmil commented Feb 28, 2023

Happy to. But I wonder why you specifically need a new release?

You should be referring to the repo by commit ID for hermeticity.

@filmil
Copy link
Owner

filmil commented Feb 28, 2023

To wit, I don't think that bazel-bats really benefits from "releasing" since it's just the source code that gets bundled in the archive anyways. I know we now have the http_archive repo rule in WORKSPACE, but I'm reconsidering it.

@fmorency
Copy link
Contributor Author

Based on your README, I've been using http_archive in our project. Happy to change if you can provide a new README with updated instructions.

@filmil
Copy link
Owner

filmil commented Feb 28, 2023

I understand. You can convert your use to git_archive, or you can wait for an update to the README.md.

@filmil
Copy link
Owner

filmil commented Mar 1, 2023

The instructions in README.md are now fixed. Please try and report back if it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants