Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Can we have async version of the library? That utilizes httpx or just so that functions can be awaited #55

Closed
Omigirl opened this issue Nov 7, 2024 · 1 comment · Fixed by #56
Closed

[FEAT] Can we have async version of the library? That utilizes httpx or just so that functions can be awaited #55

Omigirl opened this issue Nov 7, 2024 · 1 comment · Fixed by #56
Assignees
@filipporomani
Labels
enhancement New feature or request good first issue Good for newcomers working on

Comments

@Omigirl
Copy link

Omigirl commented Nov 7, 2024

Is your feature request related to a problem? Please describe.
Systems I am now working with are mainly asynchronous, but this library is synchronous so I avoid using it on my async projects.
However, I love using this library it is so much more convenient

Describe the solution you'd like
Option to create Async class. Like from whatsapp import AsyncWhatsApp
@filipporomani
Copy link
Owner

Hello!
Thanks for your suggestion. I'll implement the async functionalities ASAP.

@filipporomani filipporomani self-assigned this Nov 7, 2024
@filipporomani filipporomani added enhancement New feature or request good first issue Good for newcomers working on labels Nov 7, 2024
@filipporomani filipporomani moved this to In Progress in whatsapp module roadmap Nov 7, 2024
@filipporomani filipporomani linked a pull request Nov 15, 2024 that will close this issue
feat: async implementation #56
Merged
@filipporomani filipporomani mentioned this issue Nov 15, 2024
Merged
filipporomani added a commit that referenced this issue Nov 15, 2024
@filipporomani
feat: async implementation (#56)
f1efe41 
Full asyncronous implementation of the library. 
For more infos please read the [dedicated wiki
page](https://github.com/filipporomani/whatsapp-python/wiki/Async)

Thanks to @Omigirl for the suggestion!

As this feature is still being tested, you may encounter bugs while
using it. In such case, please report them here so I can fix the ASAP! 😄


This closes #55.
@github-project-automation github-project-automation bot moved this from In Progress to Done in whatsapp module roadmap Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipporomani filipporomani

Labels
enhancement New feature or request good first issue Good for newcomers working on
Projects
whatsapp module roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: async implementation filipporomani/whatsapp-python
2 participants
@Omigirl @filipporomani